diff options
| author | João Reis <reis@janeasystems.com> | 2018-07-12 00:25:18 +0300 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-07-27 10:43:43 +0300 |
| commit | 48e5b350b3dd236353e3e8e1196a09f5c5bcda77 (patch) | |
| tree | 20927e0bcdb88fa5abd3f14c06ae532aa740c93e /deps | |
| parent | 186c2fb6d88c473c6b811f36c87656785131b2d7 (diff) | |
build,win,v8: allow precompiling objects-inl.h
This makes compiling v8_base much faster on Windows.
Sharding is disabled because the header would have to be precompiled
for each shard but is only once. The library is much smaller, so
sharding is unnecessary.
This is enabled by default, but disabled for CI and releases.
PR-URL: https://github.com/nodejs/node/pull/21772
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/gypfiles/v8.gyp | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/deps/v8/gypfiles/v8.gyp b/deps/v8/gypfiles/v8.gyp index af5ffdc41b8..08abec1c3e5 100644 --- a/deps/v8/gypfiles/v8.gyp +++ b/deps/v8/gypfiles/v8.gyp @@ -1844,10 +1844,20 @@ 'gyp_generators': '<!(echo $GYP_GENERATORS)', }, 'msvs_disabled_warnings': [4351, 4355, 4800], - # When building Official, the .lib is too large and exceeds the 2G - # limit. This breaks it into multiple pieces to avoid the limit. - # See http://crbug.com/485155. - 'msvs_shard': 4, + 'conditions': [ + ['node_use_pch!="true"', { + # When building Official, the .lib is too large and exceeds the 2G + # limit. This breaks it into multiple pieces to avoid the limit. + # See http://crbug.com/485155. + 'msvs_shard': 4, + }, { + 'msvs_precompiled_header': 'tools/msvs/pch/pch_v8_base.h', + 'msvs_precompiled_source': '../../../tools/msvs/pch/pch_v8_base.cc', + 'sources': [ + '../../../tools/msvs/pch/pch_v8_base.cc', + ], + }], + ], # This will prevent V8's .cc files conflicting with the inspector's # .cpp files in the same shard. 'msvs_settings': { |