diff options
| author | Matheus Marchini <mat@mmarchini.me> | 2018-09-17 22:22:59 +0300 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2018-10-17 21:21:31 +0300 |
| commit | 5d44fe671c114f4d65b72216ce9a593be9225791 (patch) | |
| tree | 6200773c58f7eb9db5bfd3ef44a89aa096ba7889 /deps | |
| parent | 86db67cae4c2c2887cb224bf85320b14214ae73f (diff) | |
deps: backport 958b761 from upstream V8
Original commit message:
[postmortem] add postmortem metadata for symbols
As discussed in https://github.com/nodejs/llnode/issues/156, we need
postmortem metadata for Symbols to properly print Symbol property
names in postmortem debugging tools. Patch suggested by Ben
Noordhuis
(https://github.com/nodejs/llnode/issues/156#issuecomment-350467852).
R=bmeurer@google.com, yangguo@google.com
Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118
Reviewed-on: https://chromium-review.googlesource.com/1205052
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55632}
Refs: https://github.com/v8/v8/commit/958b761d3392495c3bf635e97fb9bd0e45
PR-URL: https://github.com/nodejs/node/pull/22914
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/BUILD.gn | 2 | ||||
| -rw-r--r-- | deps/v8/gypfiles/v8.gyp | 2 | ||||
| -rw-r--r-- | deps/v8/tools/gen-postmortem-metadata.py | 7 |
3 files changed, 5 insertions, 6 deletions
diff --git a/deps/v8/BUILD.gn b/deps/v8/BUILD.gn index c6a58776cd6..7e3406fb676 100644 --- a/deps/v8/BUILD.gn +++ b/deps/v8/BUILD.gn @@ -865,6 +865,8 @@ action("postmortem-metadata") { "src/objects/js-regexp-string-iterator.h", "src/objects/map.h", "src/objects/map-inl.h", + "src/objects/name.h", + "src/objects/name-inl.h", "src/objects/scope-info.h", "src/objects/script.h", "src/objects/script-inl.h", diff --git a/deps/v8/gypfiles/v8.gyp b/deps/v8/gypfiles/v8.gyp index c71ecded76e..f47cf075bb6 100644 --- a/deps/v8/gypfiles/v8.gyp +++ b/deps/v8/gypfiles/v8.gyp @@ -2649,6 +2649,8 @@ '../src/objects/js-regexp-string-iterator.h', '../src/objects/map.h', '../src/objects/map-inl.h', + '../src/objects/name.h', + '../src/objects/name-inl.h', '../src/objects/scope-info.h', '../src/objects/script.h', '../src/objects/script-inl.h', diff --git a/deps/v8/tools/gen-postmortem-metadata.py b/deps/v8/tools/gen-postmortem-metadata.py index 8191c8152f5..9bc1dd66d59 100644 --- a/deps/v8/tools/gen-postmortem-metadata.py +++ b/deps/v8/tools/gen-postmortem-metadata.py @@ -418,14 +418,9 @@ def load_objects_from_file(objfilename, checktypes): # for type in types: # - # Symbols and Strings are implemented using the same classes. - # - usetype = re.sub('SYMBOL_', 'STRING_', type); - - # # REGEXP behaves like REG_EXP, as in JS_REGEXP_TYPE => JSRegExp. # - usetype = re.sub('_REGEXP_', '_REG_EXP_', usetype); + usetype = re.sub('_REGEXP_', '_REG_EXP_', type); # # Remove the "_TYPE" suffix and then convert to camel case, |