diff options
| author | Darshan Sen <raisinten@gmail.com> | 2022-04-05 16:55:51 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-04-05 16:55:51 +0300 |
| commit | 0187bc5cdcffdb80763792d32666d0814bb265fc (patch) | |
| tree | 9292c184d3e6404d7babe2504d975d016c754ed6 /doc/api/v8.md | |
| parent | 818284b68737bbb9098cf12b1b221cbb24f06ce8 (diff) | |
v8: make v8.writeHeapSnapshot() error codes consistent
This change makes the error codes returned by v8.writeHeapSnapshot()
consistent across all platforms by using the libuv APIs instead of
fopen(), fwrite() and fclose(). This also starts reporting potential
errors that might happen during the write operations.
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/42577
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'doc/api/v8.md')
| -rw-r--r-- | doc/api/v8.md | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/doc/api/v8.md b/doc/api/v8.md index b04e4f6228b..ca38d2ff703 100644 --- a/doc/api/v8.md +++ b/doc/api/v8.md @@ -278,6 +278,9 @@ changes: - version: REPLACEME pr-url: https://github.com/nodejs/node/pull/41373 description: An exception will now be thrown if the file could not be written. + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/42577 + description: Make the returned error codes consistent across all platforms. --> * `filename` {string} The file path where the V8 heap snapshot is to be |