diff options
| author | Lew Gordon <lew.gordon@genesys.com> | 2021-07-08 18:43:26 +0300 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2021-07-28 23:39:33 +0300 |
| commit | fce53031e5efc20f1e5601bc907d6f1926439497 (patch) | |
| tree | cf27e4b46d7a5c3a2b160d2f37a98672ab129d35 /doc/api | |
| parent | 7f167f49dddb48fb29d4b5e5a5aa126163af4e76 (diff) | |
http: decodes url.username and url.password for authorization header
This change properly decodes the url.username and url.password for
the authorization header constructed from the URL object for
http(s) requests.
Fixes: https://github.com/nodejs/node/issues/31439
PR-URL: https://github.com/nodejs/node/pull/39310
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'doc/api')
| -rw-r--r-- | doc/api/http.md | 4 | ||||
| -rw-r--r-- | doc/api/https.md | 4 |
2 files changed, 8 insertions, 0 deletions
diff --git a/doc/api/http.md b/doc/api/http.md index 34cbf0a8e2b..9c35e5d090a 100644 --- a/doc/api/http.md +++ b/doc/api/http.md @@ -2835,6 +2835,10 @@ This can be overridden for servers and client requests by passing the <!-- YAML added: v0.3.6 changes: + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/39310 + description: When using a `URL` object parsed username and + password will now be properly URI decoded. - version: - v15.3.0 - v14.17.0 diff --git a/doc/api/https.md b/doc/api/https.md index f4c1f0487a7..f74f48c9cb5 100644 --- a/doc/api/https.md +++ b/doc/api/https.md @@ -251,6 +251,10 @@ Global instance of [`https.Agent`][] for all HTTPS client requests. <!-- YAML added: v0.3.6 changes: + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/39310 + description: When using a `URL` object parsed username + and password will now be properly URI decoded. - version: - v14.1.0 - v13.14.0 |