diff options
| author | Michael Dawson <michael_dawson@ca.ibm.com> | 2019-07-17 21:39:56 +0300 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-07-20 22:32:06 +0300 |
| commit | 6c075238b0f1019f38a56d6a93f6f7b0f3eeeda0 (patch) | |
| tree | 0d5ababa526883c99eca6f03790f0ac6eb27a9ed /doc/api | |
| parent | f9c267e9514f1363c72f062a5971ae07dbe32634 (diff) | |
doc: amplify warning for execute callback
Add specific recommendation not to use the
to the napi-env parameter in napi_async_execute_callback
PR-URL: https://github.com/nodejs/node/pull/28738
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'doc/api')
| -rw-r--r-- | doc/api/n-api.md | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/doc/api/n-api.md b/doc/api/n-api.md index 014cbcd6204..e4b9e4c896d 100644 --- a/doc/api/n-api.md +++ b/doc/api/n-api.md @@ -463,6 +463,8 @@ Implementations of this type of function should avoid making any N-API calls that could result in the execution of JavaScript or interaction with JavaScript objects. Most often, any code that needs to make N-API calls should be made in `napi_async_complete_callback` instead. +Avoid using the `napi_env` parameter in the execute callback as +it will likely execute JavaScript. #### napi_async_complete_callback <!-- YAML @@ -4028,6 +4030,8 @@ The `execute` function should avoid making any N-API calls that could result in the execution of JavaScript or interaction with JavaScript objects. Most often, any code that needs to make N-API calls should be made in `complete` callback instead. +Avoid using the `napi_env` parameter in the execute callback as +it will likely execute JavaScript. These functions implement the following interfaces: |