diff options
| author | Rod Vagg <rod@vagg.org> | 2018-01-08 08:01:39 +0300 |
|---|---|---|
| committer | Myles Borins <mylesborins@google.com> | 2018-05-15 21:01:37 +0300 |
| commit | ab4809f195836b5be79026e436e90370366c81ea (patch) | |
| tree | 5faf59b5ce9606793171c87deba91d73ddc48d7b /doc/api | |
| parent | a52f15efae252f7c3b6781c13da4b63d746aaec4 (diff) | |
build,win: restore vcbuild TAG functionality
--tag needs to be set after `getnodeversion` because TAG is defined in
there when DISTTYPE is not "release", setting it before `getnodeversion`
leads to --tag not being passed down in to `configure` and
src/node_version.h setting it as `-pre` by default. This change restores
the functionality that properly sets the TAG for nightlies, rc builds
and other custom build types.
Ref: https://github.com/nodejs/node/pull/17299
Ref: https://github.com/nodejs/abi-stable-node/issues/289
PR-URL: https://github.com/nodejs/node/pull/18031
Ref: https://github.com/nodejs/node/pull/17299
Ref: https://github.com/nodejs/abi-stable-node/issues/289
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: JoãReis <reis@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Diffstat (limited to 'doc/api')
0 files changed, 0 insertions, 0 deletions