diff options
| author | Lew Gordon <lew.gordon@genesys.com> | 2021-07-08 18:43:26 +0300 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2021-09-04 16:14:39 +0300 |
| commit | 2bc301dcff7f8d37dbd655e7816c4d38b9ce0f8b (patch) | |
| tree | aa0f9c25d76004aea1685d62ef401e0cdc17e560 /doc | |
| parent | a437de3c5f403562f27041f1aa81efbac234ba3e (diff) | |
http: decodes url.username and url.password for authorization header
This change properly decodes the url.username and url.password for
the authorization header constructed from the URL object for
http(s) requests.
Fixes: https://github.com/nodejs/node/issues/31439
PR-URL: https://github.com/nodejs/node/pull/39310
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/api/http.md | 4 | ||||
| -rw-r--r-- | doc/api/https.md | 4 |
2 files changed, 8 insertions, 0 deletions
diff --git a/doc/api/http.md b/doc/api/http.md index b04890e97c4..c4d5173ce07 100644 --- a/doc/api/http.md +++ b/doc/api/http.md @@ -2767,6 +2767,10 @@ This can be overridden for servers and client requests by passing the <!-- YAML added: v0.3.6 changes: + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/39310 + description: When using a `URL` object parsed username and + password will now be properly URI decoded. - version: v14.17.0 pr-url: https://github.com/nodejs/node/pull/36048 description: It is possible to abort a request with an AbortSignal. diff --git a/doc/api/https.md b/doc/api/https.md index f7cc2a34010..1c0b601cfbe 100644 --- a/doc/api/https.md +++ b/doc/api/https.md @@ -251,6 +251,10 @@ Global instance of [`https.Agent`][] for all HTTPS client requests. <!-- YAML added: v0.3.6 changes: + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/39310 + description: When using a `URL` object parsed username + and password will now be properly URI decoded. - version: v14.1.0 pr-url: https://github.com/nodejs/node/pull/32786 description: The `highWaterMark` option is accepted now. |