diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2021-08-23 09:23:44 +0300 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2021-09-04 16:14:56 +0300 |
| commit | 8efd559347e2a0f98f7705fcb2a8236869133c48 (patch) | |
| tree | dcb06afbc6d9ea02d44d3acd38e2039b77bf7931 /doc | |
| parent | 5e1cba81bf9caf217c37969e76f3ccb776f50948 (diff) | |
doc: add duplicate CVE check in sec. release doc
This commit adds a note about only creating a CVE for Node.js
vulnerabilities.
The motivation for this is a recent HackerOne report where I created a
CVE for a c-ares issue. This CVE should have been created by the c-ares
project, and it was later, but we never updated our HackerOne report to
use their CVE number. Hopefully this extra note in the release doc will
help us check for this situaion and avoid this in the future.
PR-URL: https://github.com/nodejs/node/pull/39845
Refs: https://hackerone.com/reports/1178337
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/guides/security-release-process.md | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/doc/guides/security-release-process.md b/doc/guides/security-release-process.md index a0986a5c04a..bcad4687ccb 100644 --- a/doc/guides/security-release-process.md +++ b/doc/guides/security-release-process.md @@ -40,6 +40,9 @@ information described. * Approved * Pass `make test` * Have CVEs + * Make sure that dependent libraries have CVEs for their issues. We should + only create CVEs for vulnerabilities in Node.js itself. This is to avoid + having duplicate CVEs for the same vulnerability. * Described in the pre/post announcements * [ ] Pre-release announcement [email][]: ***LINK TO EMAIL*** |