diff options
| author | Timothy Gu <timothygu99@gmail.com> | 2017-09-30 08:15:24 +0300 |
|---|---|---|
| committer | Evan Lucas <evanlucas@me.com> | 2017-10-23 17:14:26 +0300 |
| commit | 0b048698600d20701ae0151441849b2a6993127b (patch) | |
| tree | 5f90f48245c4f89a9f5bcddd7fc8974877a4a9e8 /doc | |
| parent | b1a68f52e2172b565f5f4d8f08c65a45c023dbf3 (diff) | |
src: do not add .domain to promises in VM contexts
The promises are still tracked, and their handlers will still execute in
the correct domain. The creation domain is simply hidden.
Backport-PR-URL: https://github.com/nodejs/node/pull/16074
PR-URL: https://github.com/nodejs/node/pull/15695
Fixes: https://github.com/nodejs/node/issues/15673
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/api/domain.md | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/doc/api/domain.md b/doc/api/domain.md index a4a31d4fecd..e7d0166348b 100644 --- a/doc/api/domain.md +++ b/doc/api/domain.md @@ -1,6 +1,12 @@ # Domain <!-- YAML changes: + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/REPLACEME + description: Any `Promise`s created in VM contexts no longer have a + `.domain` property. Their handlers are still executed in the + proper domain, however, and `Promise`s created in the main + context still possess a `.domain` property. - version: v8.0.0 pr-url: https://github.com/nodejs/node/pull/12489 description: Handlers for `Promise`s are now invoked in the domain in which |