diff options
| author | James M Snell <jasnell@gmail.com> | 2018-10-19 21:21:42 +0300 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2018-10-25 19:03:32 +0300 |
| commit | 1523111250788e0e1651d30c1fd506e9ef4ac7f0 (patch) | |
| tree | 5935190f25093fb28173a4323dc971336edd32dc /lib/internal/child_process.js | |
| parent | 24cb1f33d85fbb8e5cc9c10f488766ca8a21ddca (diff) | |
net: deprecate _setSimultaneousAccepts() undocumented function
This is an undocumented utility function that is of questionable
utility.
Fixes: https://github.com/nodejs/node/issues/18391
PR-URL: https://github.com/nodejs/node/pull/23760
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'lib/internal/child_process.js')
| -rw-r--r-- | lib/internal/child_process.js | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/lib/internal/child_process.js b/lib/internal/child_process.js index 74d69de0dcd..a2478ec69de 100644 --- a/lib/internal/child_process.js +++ b/lib/internal/child_process.js @@ -604,8 +604,7 @@ function setupChannel(target, channel) { // Update simultaneous accepts on Windows if (process.platform === 'win32') { - handle._simultaneousAccepts = false; - net._setSimultaneousAccepts(handle); + handle.setSimultaneousAccepts(false); } // Convert handle object @@ -700,8 +699,8 @@ function setupChannel(target, channel) { message = message.msg; // Update simultaneous accepts on Windows - if (obj.simultaneousAccepts) { - net._setSimultaneousAccepts(handle); + if (obj.simultaneousAccepts && process.platform === 'win32') { + handle.setSimultaneousAccepts(true); } } else if (this._handleQueue && !(message && (message.cmd === 'NODE_HANDLE_ACK' || |