diff options
author | Yash Ladha <yashladhapankajladha123@gmail.com> | 2020-04-21 10:25:58 +0300 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2020-04-27 20:32:49 +0300 |
commit | b2768ae185bf1256282ea2fda9a04dd3b7bbf1bf (patch) | |
tree | 6dcc2d4401a95f3e35ff271900e64d40e9168008 /lib/internal/cluster | |
parent | 20e0cc0592270bac03852120ec05f4b483b05ccb (diff) |
cluster: removed unused addressType argument from constructor
When intializing the constructor for cluster master we are heavily using
a generic structure, but the effect of passing arguments that are
related to shared_handle is that there is a stale argument passed.
We can avoid such scenarios as all the remaining entities are being
destructured from the message object.
PR-URL: https://github.com/nodejs/node/pull/32963
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Diffstat (limited to 'lib/internal/cluster')
-rw-r--r-- | lib/internal/cluster/master.js | 7 | ||||
-rw-r--r-- | lib/internal/cluster/round_robin_handle.js | 2 | ||||
-rw-r--r-- | lib/internal/cluster/shared_handle.js | 2 |
3 files changed, 3 insertions, 8 deletions
diff --git a/lib/internal/cluster/master.js b/lib/internal/cluster/master.js index dc8efc1f98e..9d6d4df6316 100644 --- a/lib/internal/cluster/master.js +++ b/lib/internal/cluster/master.js @@ -297,12 +297,7 @@ function queryServer(worker, message) { constructor = SharedHandle; } - handle = new constructor(key, - address, - message.port, - message.addressType, - message.fd, - message.flags); + handle = new constructor(key, address, message); handles.set(key, handle); } diff --git a/lib/internal/cluster/round_robin_handle.js b/lib/internal/cluster/round_robin_handle.js index 213b72c19f4..492fd725c82 100644 --- a/lib/internal/cluster/round_robin_handle.js +++ b/lib/internal/cluster/round_robin_handle.js @@ -13,7 +13,7 @@ const { constants } = internalBinding('tcp_wrap'); module.exports = RoundRobinHandle; -function RoundRobinHandle(key, address, port, addressType, fd, flags) { +function RoundRobinHandle(key, address, { port, fd, flags }) { this.key = key; this.all = new Map(); this.free = new Map(); diff --git a/lib/internal/cluster/shared_handle.js b/lib/internal/cluster/shared_handle.js index 20c028ce313..656b1292988 100644 --- a/lib/internal/cluster/shared_handle.js +++ b/lib/internal/cluster/shared_handle.js @@ -6,7 +6,7 @@ const net = require('net'); module.exports = SharedHandle; -function SharedHandle(key, address, port, addressType, fd, flags) { +function SharedHandle(key, address, { port, addressType, fd, flags }) { this.key = key; this.workers = new Map(); this.handle = null; |