diff options
author | Beni von Cheni <benjaminlchen@gmail.com> | 2019-03-22 07:22:42 +0300 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-03-27 07:59:43 +0300 |
commit | ed5e69d7e6eaf5e887ff48aa3fe941d394c44846 (patch) | |
tree | eb849fc392f95f5dfb260a082ddbd0706fbff9d6 /lib/internal/console | |
parent | 6342af7ebdd6cd516507fba5a91ffc6878ef7cfb (diff) |
console: use consolePropAttributes for k-bind properties in constructor
PR-URL: https://github.com/nodejs/node/pull/26850
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'lib/internal/console')
-rw-r--r-- | lib/internal/console/constructor.js | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js index b00707d1fda..fadb80e707c 100644 --- a/lib/internal/console/constructor.js +++ b/lib/internal/console/constructor.js @@ -181,15 +181,13 @@ Console.prototype[kBindProperties] = function(ignoreErrors, colorMode) { ...consolePropAttributes, value: Boolean(ignoreErrors) }, - '_times': { ...consolePropAttributes, value: new Map() } + '_times': { ...consolePropAttributes, value: new Map() }, + // Corresponds to https://console.spec.whatwg.org/#count-map + [kCounts]: { ...consolePropAttributes, value: new Map() }, + [kColorMode]: { ...consolePropAttributes, value: colorMode }, + [kIsConsole]: { ...consolePropAttributes, value: true }, + [kGroupIndent]: { ...consolePropAttributes, value: '' } }); - - // TODO(joyeecheung): use consolePropAttributes for these - // Corresponds to https://console.spec.whatwg.org/#count-map - this[kCounts] = new Map(); - this[kColorMode] = colorMode; - this[kIsConsole] = true; - this[kGroupIndent] = ''; }; // Make a function that can serve as the callback passed to `stream.write()`. |