diff options
author | Rich Trott <rtrott@gmail.com> | 2020-08-09 02:39:05 +0300 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2020-08-11 02:33:49 +0300 |
commit | 8a8416f84169c553380704ab3a754db0a1735877 (patch) | |
tree | ef47f10f23eb717c5f823450240ae195058a1a1c /lib/internal/event_target.js | |
parent | bcfb1762a3e613e71ac68ab8a6420e2f33c0f603 (diff) |
lib: use full URL to GitHub issues in comments
Don't assume the reader of the code will know where to find the issue
tracker. Provide the full URL. This is especially important if the
issue tracker should move again.
PR-URL: https://github.com/nodejs/node/pull/34686
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib/internal/event_target.js')
-rw-r--r-- | lib/internal/event_target.js | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js index a2a6452a3fc..8f0657c8d5b 100644 --- a/lib/internal/event_target.js +++ b/lib/internal/event_target.js @@ -201,7 +201,8 @@ function initEventTarget(self) { class EventTarget { // Used in checking whether an object is an EventTarget. This is a well-known - // symbol as EventTarget may be used cross-realm. See discussion in #33661. + // symbol as EventTarget may be used cross-realm. + // Ref: https://github.com/nodejs/node/pull/33661 static [kIsEventTarget] = true; constructor() { @@ -520,8 +521,8 @@ function validateEventListenerOptions(options) { // Test whether the argument is an event object. This is far from a fool-proof // test, for example this input will result in a false positive: // > isEventTarget({ constructor: EventTarget }) -// It stands in its current implementation as a compromise. For the relevant -// discussion, see #33661. +// It stands in its current implementation as a compromise. +// Ref: https://github.com/nodejs/node/pull/33661 function isEventTarget(obj) { return obj && obj.constructor && obj.constructor[kIsEventTarget]; } |