Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2020-08-09 02:39:05 +0300
committerRich Trott <rtrott@gmail.com>2020-08-11 02:33:49 +0300
commit8a8416f84169c553380704ab3a754db0a1735877 (patch)
treeef47f10f23eb717c5f823450240ae195058a1a1c /lib/internal/stream_base_commons.js
parentbcfb1762a3e613e71ac68ab8a6420e2f33c0f603 (diff)
lib: use full URL to GitHub issues in comments
Don't assume the reader of the code will know where to find the issue tracker. Provide the full URL. This is especially important if the issue tracker should move again. PR-URL: https://github.com/nodejs/node/pull/34686 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib/internal/stream_base_commons.js')
-rw-r--r--lib/internal/stream_base_commons.js6
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/internal/stream_base_commons.js b/lib/internal/stream_base_commons.js
index cef87c4cfdf..0dfee0c9c7b 100644
--- a/lib/internal/stream_base_commons.js
+++ b/lib/internal/stream_base_commons.js
@@ -208,7 +208,8 @@ function onStreamRead(arrayBuffer) {
}
if (nread !== UV_EOF) {
- // #34375 CallJSOnreadMethod expects the return value to be a buffer.
+ // CallJSOnreadMethod expects the return value to be a buffer.
+ // Ref: https://github.com/nodejs/node/pull/34375
stream.destroy(errnoException(nread, 'read'));
return;
}
@@ -228,7 +229,8 @@ function onStreamRead(arrayBuffer) {
if (handle.readStop) {
const err = handle.readStop();
if (err) {
- // #34375 CallJSOnreadMethod expects the return value to be a buffer.
+ // CallJSOnreadMethod expects the return value to be a buffer.
+ // Ref: https://github.com/nodejs/node/pull/34375
stream.destroy(errnoException(err, 'read'));
return;
}