diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2018-03-03 23:55:45 +0300 |
---|---|---|
committer | Joyee Cheung <joyeec9h3@gmail.com> | 2018-03-06 17:12:46 +0300 |
commit | 2a9eb316a1e86d8b191aa2cdfd25d45508456573 (patch) | |
tree | 743074a353fc55583bbec14e4d56a27ea0911bc8 /lib/internal/test | |
parent | 1a5ec837ca56774f2a9ee54ee9a0f6cbfa01d4bc (diff) |
src: move internal loaders out of bootstrap_node.js
- Moves the creation of `process.binding()`, `process._linkedBinding()`
`internalBinding()` and `NativeModule` into a separate file
`lib/internal/bootstrap_loaders.js`, and documents them there.
This file will be compiled and run before `bootstrap_node.js`, which
means we now bootstrap the internal module & binding system before
actually bootstrapping Node.js.
- Rename the special ID that can be used to require `NativeModule`
as `internal/bootstrap_loaders` since it is setup there. Also put
`internalBinding` in the object exported by `NativeModule.require`
instead of putting it inside the `NativeModule.wrapper`
- Use the original `getBinding()` to get the source code of native
modules instead of getting it from `process.binding('native')`
so that users cannot fake native modules by modifying the binding
object.
- Names the bootstrapping functions so their names show up
in the stack trace.
PR-URL: https://github.com/nodejs/node/pull/19112
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Diffstat (limited to 'lib/internal/test')
-rw-r--r-- | lib/internal/test/binding.js | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/internal/test/binding.js b/lib/internal/test/binding.js index 7b9e1a089d2..aae89ce7a0f 100644 --- a/lib/internal/test/binding.js +++ b/lib/internal/test/binding.js @@ -8,6 +8,7 @@ process.emitWarning( // These exports should be scoped as specifically as possible // to avoid exposing APIs because even with that warning and // this file being internal people will still try to abuse it. +const { internalBinding } = require('internal/bootstrap_loaders'); module.exports = { ModuleWrap: internalBinding('module_wrap').ModuleWrap, }; |