tickprocessor: apply c++filt manually on mac

`/bin/sh -c` trick wasn't working for several reasons:

* `/bin/sh -c "..."` expects the first argument after `"..."` to be a
  `$0`, not a `$1`. Previously `-n` wasn't passed to `nm` because of
  this, and many symbols were ordered improperly
* `c++filt` was applied not only to the names of the functions but to
  their `nm` prefixes like `t` and `a` (`t xxx` turns into
  `unsigned char xxx`).

Instead of applying `c++filt` wide and using `sh -c`, execute `nm` as
requested by `deps/v8/tools/tickprocessor.js` and apply `c++filt` to all
matching entries manually.

Included test demonstrates where previous approach failed: all builtins
were merged into `v8::internal::Builtins::~Builtins`, because they were
prefixed by `t` in `nm` output.

PR-URL: https://github.com/nodejs/node/pull/8480
Reviewed-By: Matthew Loring <mattloring@google.com>

1 files changed, 1 insertions, 2 deletions

diff --git a/lib/internal/v8_prof_processor.js b/lib/internal/v8_prof_processor.js
index 86f06629e1b..95b6254599a 100644
--- a/lib/internal/v8_prof_processor.js
+++ b/lib/internal/v8_prof_processor.js
@@ -20,8 +20,7 @@ scriptFiles.forEach(function(s) {
 
 var tickArguments = [];
 if (process.platform === 'darwin') {
-  const nm = 'foo() { nm "$@" | (c++filt -p -i || cat) }; foo $@';
-  tickArguments.push('--mac', '--nm=' + nm);
+  tickArguments.push('--mac');
 } else if (process.platform === 'win32') {
   tickArguments.push('--windows');
 }