tls: retry writing after hello parse error

When writing bad data to EncryptedStream it'll first get to the
ClientHello parser, and, only after it will refuse it, to the OpenSSL.
But ClientHello parser has limited buffer and therefore write could
return `bytes_written` < `incoming_bytes`, which is not the case when
working with OpenSSL.

After such errors ClientHello parser disables itself and will
pass-through all data to the OpenSSL. So just trying to write data one
more time will throw the rest into OpenSSL and let it handle it.

1 files changed, 8 insertions, 1 deletions

diff --git a/lib/tls.js b/lib/tls.js
index 1ff0d5d679a..7bf0ca18865 100644
--- a/lib/tls.js
+++ b/lib/tls.js
@@ -253,6 +253,7 @@ function CryptoStream(pair, options) {
   this._pendingEncoding = '';
   this._pendingCallback = null;
   this._doneFlag = false;
+  this._retryAfterPartial = false;
   this._resumingSession = false;
   this._reading = true;
   this._destroyed = false;
@@ -361,7 +362,13 @@ CryptoStream.prototype._write = function write(data, encoding, cb) {
 
       return cb(null);
     }
-    assert(written === 0 || written === -1);
+    if (written !== 0 && written !== -1) {
+      assert(!this._retryAfterPartial);
+      this._retryAfterPartial = true;
+      this._write(data.slice(written), encoding, cb);
+      this._retryAfterPartial = false;
+      return;
+    }
   } else {
     debug('cleartext.write queue is full');