diff options
| author | Qingyu Deng <bitdqy@hotmail.com> | 2021-02-10 08:10:36 +0300 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2021-05-01 13:25:07 +0300 |
| commit | 105b8630b9be0e3340ea8139af00925b4da6ece1 (patch) | |
| tree | 0fda3f7f957f8179b7c96c78af3bee620cd6f25a /lib | |
| parent | 926bb4fd170ce0031f2f77d5fac8189676ccaf4a (diff) | |
http: explain the possibilty of refactor unused argument
PR-URL: https://github.com/nodejs/node/pull/37275
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/_http_incoming.js | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/_http_incoming.js b/lib/_http_incoming.js index 7bf66fbddb8..628043aaf76 100644 --- a/lib/_http_incoming.js +++ b/lib/_http_incoming.js @@ -104,6 +104,10 @@ IncomingMessage.prototype.setTimeout = function setTimeout(msecs, callback) { // argument adaptor frame creation inside V8 in case that number of actual // arguments is different from expected arguments. // Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10201 +// NOTE: Argument adapt frame issue might be solved in V8 engine v8.9. +// Refactoring `n` out might be possible when V8 is upgraded to that +// version. +// Ref: https://v8.dev/blog/v8-release-89 IncomingMessage.prototype._read = function _read(n) { if (!this._consuming) { this._readableState.readingMore = false; |