diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2013-04-18 02:44:53 +0400 |
|---|---|---|
| committer | Ben Noordhuis <info@bnoordhuis.nl> | 2013-04-18 02:54:57 +0400 |
| commit | 92023b4b37ad9bd1609b2dd2a13680dafc429f75 (patch) | |
| tree | 815b1fd1368609941b3576f7e3de207baaa9c1f4 /lib | |
| parent | 2e70ddad9d8ef8aa37bcb18ef912cf0ff5921656 (diff) | |
dgram: fix no address bind()
I broke dgram.Socket#bind(port, cb) almost a year ago in 332fea5a but
it wasn't until today that someone complained and none of the tests
caught it because they all either specify the address or omit the
callback.
Anyway, now it works again and does what you expect: it binds the
socket to the "any" address ("0.0.0.0" for IPv4 and "::" for IPv6.)
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/dgram.js | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/dgram.js b/lib/dgram.js index e13f066710b..05997810e60 100644 --- a/lib/dgram.js +++ b/lib/dgram.js @@ -176,6 +176,7 @@ Socket.prototype.bind = function(/*port, address, callback*/) { var port = arguments[0]; var address = arguments[1]; + if (typeof address === 'function') address = ''; // a.k.a. "any address" // resolve address first self._handle.lookup(address, function(err, ip) { |