Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorWeijia Wang <381152119@qq.com>2017-10-08 05:36:28 +0300
committerMichaƫl Zasso <targos@protonmail.com>2017-10-18 07:10:01 +0300
commit6ff397db8979112daeb784b22ec2b3944fd6fce9 (patch)
tree77de318a798bfad129123725f0728f92594283d3 /lib
parent8a151bedfbb0d1fc32e4eab6ab1c6742d1205a43 (diff)
url: using util._extend for improving profermace
`Object.assign` is much slower than `util._extend` according to the refs. This change is to convert the `Object.assign` to use `util._extend` in url module for improving profermance. PR-URL: https://github.com/nodejs/node/pull/16081 Refs: https://github.com/nodejs/CTC/issues/62 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Diffstat (limited to 'lib')
-rw-r--r--lib/internal/url.js6
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/internal/url.js b/lib/internal/url.js
index 54a23e02515..80dee85c99f 100644
--- a/lib/internal/url.js
+++ b/lib/internal/url.js
@@ -170,7 +170,7 @@ class URLSearchParams {
return ctx.stylize('[Object]', 'special');
var separator = ', ';
- var innerOpts = Object.assign({}, ctx);
+ var innerOpts = util._extend({}, ctx);
if (recurseTimes !== null) {
innerOpts.depth = recurseTimes - 1;
}
@@ -373,7 +373,7 @@ Object.defineProperties(URL.prototype, {
value: function format(options) {
if (options && typeof options !== 'object')
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'options', 'object');
- options = Object.assign({
+ options = util._extend({
fragment: true,
unicode: false,
search: true,
@@ -1244,7 +1244,7 @@ defineIDLClass(URLSearchParamsIteratorPrototype, 'URLSearchParamsIterator', {
if (typeof recurseTimes === 'number' && recurseTimes < 0)
return ctx.stylize('[Object]', 'special');
- const innerOpts = Object.assign({}, ctx);
+ const innerOpts = util._extend({}, ctx);
if (recurseTimes !== null) {
innerOpts.depth = recurseTimes - 1;
}