diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2022-02-17 18:12:56 +0300 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2022-03-23 15:07:53 +0300 |
| commit | eb7b89c8291f057cb9c3a903b4e4a67ec95bfd7d (patch) | |
| tree | c253074cf0346cf848425baef6dbd527b994aee1 /lib | |
| parent | 9680d7df3a63128fc934ef65d5bbff2d6517e797 (diff) | |
lib: update class fields TODO in abort_controller.js
https://bugs.chromium.org/p/v8/issues/detail?id=10704 is already
fixed, but since AbortController currently throws ERR_INVALID_THIS
we'll revert to class fields in a subsequent patch. For now just
update the comments.
PR-URL: https://github.com/nodejs/node/pull/42361
Refs: https://github.com/nodejs/node/commit/b1c3909bd766327a569c2e4279a4670454f3f9db
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/internal/abort_controller.js | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/lib/internal/abort_controller.js b/lib/internal/abort_controller.js index e0c0d638999..7e89e43cc7c 100644 --- a/lib/internal/abort_controller.js +++ b/lib/internal/abort_controller.js @@ -291,9 +291,8 @@ function abortSignal(signal, reason) { signal.dispatchEvent(event); } -// TODO(joyeecheung): V8 snapshot does not support instance member -// initializers for now: -// https://bugs.chromium.org/p/v8/issues/detail?id=10704 +// TODO(joyeecheung): use private fields and we'll get invalid access +// validation from V8 instead of throwing ERR_INVALID_THIS ourselves. const kSignal = Symbol('signal'); function validateAbortController(obj) { |