diff options
author | Richard Lau <riclau@uk.ibm.com> | 2020-05-11 21:42:52 +0300 |
---|---|---|
committer | Shelley Vohr <shelley.vohr@gmail.com> | 2020-05-16 21:45:58 +0300 |
commit | 7d4db35f8482e5324e6c44a62a06d5e83658e874 (patch) | |
tree | 05fc743d82e1af519ef4d5df2886b6b350158f46 /node.gyp | |
parent | f31b262f505e473c0d8d96c79411c3e677540b81 (diff) |
build: fix `--error-on-warn` for macOS
XCode builds on macOS do not appear to inherit the `cflags` setting.
Signed-off-by: Richard Lau <riclau@uk.ibm.com>
PR-URL: https://github.com/nodejs/node/pull/33357
Refs: https://github.com/nodejs/node/pull/32685
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Diffstat (limited to 'node.gyp')
-rw-r--r-- | node.gyp | 6 |
1 files changed, 6 insertions, 0 deletions
@@ -378,6 +378,9 @@ 'conditions': [ [ 'error_on_warn=="true"', { 'cflags': ['-Werror'], + 'xcode_settings': { + 'WARNING_CFLAGS': [ '-Werror' ], + }, }], [ 'node_intermediate_lib_type=="static_library" and ' 'node_shared=="true" and OS=="aix"', { @@ -757,6 +760,9 @@ 'conditions': [ [ 'error_on_warn=="true"', { 'cflags': ['-Werror'], + 'xcode_settings': { + 'WARNING_CFLAGS': [ '-Werror' ], + }, }], [ 'node_builtin_modules_path!=""', { 'defines': [ 'NODE_BUILTIN_MODULES_PATH="<(node_builtin_modules_path)"' ] |