diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-10-22 23:03:53 +0300 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-11-08 17:53:36 +0300 |
| commit | 2bdeb88c27b4d8de3a8f6b7a438cf0bcb88fa927 (patch) | |
| tree | c86c4faa4410216460c25053ab22061ee3f9897f /node.gyp | |
| parent | 2707efd27b5ce5f9b9a6873438769394ef1c6431 (diff) | |
src: remove custom tracking for SharedArrayBuffers
Remove custom tracking for `SharedArrayBuffer`s and their allocators
and instead let V8 do the tracking of both. This is required starting
in V8 7.9, because lifetime management for `ArrayBuffer::Allocator`s
differs from what was performed previously (i.e. it is no longer
easily possible for one Isolate to release an `ArrayBuffer` and another
to accept it into its own allocator), and the alternative would
have been adapting the `SharedArrayBuffer` tracking logic to also
apply to regular `ArrayBuffer` instances.
Refs: https://github.com/nodejs/node/pull/30044
PR-URL: https://github.com/nodejs/node/pull/30020
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'node.gyp')
| -rw-r--r-- | node.gyp | 2 |
1 files changed, 0 insertions, 2 deletions
@@ -564,7 +564,6 @@ 'src/node_zlib.cc', 'src/pipe_wrap.cc', 'src/process_wrap.cc', - 'src/sharedarraybuffer_metadata.cc', 'src/signal_wrap.cc', 'src/spawn_sync.cc', 'src/stream_base.cc', @@ -642,7 +641,6 @@ 'src/pipe_wrap.h', 'src/req_wrap.h', 'src/req_wrap-inl.h', - 'src/sharedarraybuffer_metadata.h', 'src/spawn_sync.h', 'src/stream_base.h', 'src/stream_base-inl.h', |