diff options
| author | Darshan Sen <darshan.sen@postman.com> | 2021-11-13 00:47:42 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-11-13 00:47:42 +0300 |
| commit | 2d368da19f90830e993250050ccd8c6f76bd9cd7 (patch) | |
| tree | 74c4f1eae2ac5f60b17da1e634cda5819481243a /node.gyp | |
| parent | 2037ee85a28c9b54e8a84137e251118ee071aa6f (diff) | |
src: prevent extra copies of `TimerWrap::TimerCb`
I noticed that we were taking `TimerCb` as a `const&` and then copying
that into the member. This is completely fine when the constructor is
called with an lvalue. However, when called with an rvalue, we can allow
the `std::function` to be moved into the member instead of falling back
to a copy, so I changed the constructors to take in universal
references. Also, `std::function` constructors can take in multiple
arguments, so I further modified the constructors to use variadic
templates.
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
PR-URL: https://github.com/nodejs/node/pull/40665
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Diffstat (limited to 'node.gyp')
| -rw-r--r-- | node.gyp | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -642,6 +642,7 @@ 'src/tracing/trace_event_common.h', 'src/tracing/traced_value.h', 'src/timer_wrap.h', + 'src/timer_wrap-inl.h', 'src/tty_wrap.h', 'src/udp_wrap.h', 'src/util.h', |