diff options
| author | Refael Ackermann <refack@gmail.com> | 2018-09-30 20:44:55 +0300 |
|---|---|---|
| committer | Refael Ackermann <refack@gmail.com> | 2018-10-03 00:53:14 +0300 |
| commit | 6dd4a077c0fd2bcd964dd6195b80fef66b5e4c3b (patch) | |
| tree | 22608e3080f3571df2e3f2331dd0ebc147fb67ae /node.gypi | |
| parent | 1a1fe53e3dbd0042807b75caac94dcae0abe4dc1 (diff) | |
build: reduce chance of unneeded rebuild
Run `node_js2c` and `mkssldef` as actions and not as targets makes sure
they are run only once, just before processing the rest of `node_lib`.
This helps `make` based dependency change detection be more accurate.
Add comments with tagrget names for readability.
Use `process_outputs_as_sources` for automatic inclution of outputs.
PR-URL: https://github.com/nodejs/node/pull/23156
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'node.gypi')
| -rw-r--r-- | node.gypi | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/node.gypi b/node.gypi index db29084335b..fe133039d3d 100644 --- a/node.gypi +++ b/node.gypi @@ -24,6 +24,16 @@ }, 'force_load%': '<(force_load)', }, + # Putting these explicitly here so not to be dependant on common.gypi. + 'cflags': [ '-Wall', '-Wextra', '-Wno-unused-parameter', ], + 'xcode_settings': { + 'WARNING_CFLAGS': [ + '-Wall', + '-Wendif-labels', + '-W', + '-Wno-unused-parameter', + ], + }, 'conditions': [ [ 'node_shared=="false"', { 'msvs_settings': { |