diff options
author | Yihong Wang <yh.wang@ibm.com> | 2018-03-07 23:25:26 +0300 |
---|---|---|
committer | Yihong Wang <yh.wang@ibm.com> | 2018-03-13 02:56:04 +0300 |
commit | ffd618bd5cde77e19ab6458eaf454c4df71dd638 (patch) | |
tree | ce3ac6ceb25fcb8818764856d02f5407137bcb4d /node.gypi | |
parent | 0acdd8402614ce39a95a798b7e2898972332c4c7 (diff) |
test: shared lib build doesn't handle SIGPIPE
For shared lib build, we leave the signal handling for embedding users.
In these two test cases:
- `parallel/test-process-external-stdio-close-spawn`
- `parallel/test-process-external-stdio-close`
The pipe is used for stdout and is destroied before child process uses
it for logging. So the node executble that uses shared lib build
receives SIGPIPE and the child process ends.
This change ignores the SIGPIPE in node_main.cc for shared lib case.
Refs: https://github.com/nodejs/node/issues/18535
Signed-off-by: Yihong Wang <yh.wang@ibm.com>
PR-URL: https://github.com/nodejs/node/pull/19211
Refs: https://github.com/nodejs/node/issues/18535
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Diffstat (limited to 'node.gypi')
-rw-r--r-- | node.gypi | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/node.gypi b/node.gypi index 852cc18eee7..ac043dac242 100644 --- a/node.gypi +++ b/node.gypi @@ -37,6 +37,24 @@ 'NODE_SHARED_MODE', ], }], + [ 'OS=="win"', { + 'defines!': [ + 'NODE_PLATFORM="win"', + ], + 'defines': [ + 'FD_SETSIZE=1024', + # we need to use node's preferred "win32" rather than gyp's preferred "win" + 'NODE_PLATFORM="win32"', + # Stop <windows.h> from defining macros that conflict with + # std::min() and std::max(). We don't use <windows.h> (much) + # but we still inherit it from uv.h. + 'NOMINMAX', + '_UNICODE=1', + ], + }, { # POSIX + 'defines': [ '__POSIX__' ], + }], + [ 'node_enable_d8=="true"', { 'dependencies': [ 'deps/v8/src/d8.gyp:d8' ], }], |