diff options
| author | Gireesh Punathil <gpunathi@in.ibm.com> | 2020-07-21 05:44:45 +0300 |
|---|---|---|
| committer | Myles Borins <mylesborins@github.com> | 2020-07-28 01:23:44 +0300 |
| commit | 99a648738c06ecdb48db712cd5e3e5500ef43cdc (patch) | |
| tree | 2f6d591798f9d9b25b75e757f024925e39a77102 /onboarding.md | |
| parent | bbc7eeadd9bbeb275d1fc878a0e6afc51be49a85 (diff) | |
doc: onboarding process extras
Callout some practices explicitly, so that
the process is followed in a similar manner
PR-URL: https://github.com/nodejs/node/pull/34455
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Diffstat (limited to 'onboarding.md')
| -rw-r--r-- | onboarding.md | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/onboarding.md b/onboarding.md index 31b8353ef41..8ec268570e8 100644 --- a/onboarding.md +++ b/onboarding.md @@ -210,6 +210,9 @@ needs to be pointed out separately during the onboarding. * Run CI on the PR. Use the `node-test-pull-request` CI task. * After two Collaborator approvals for the change and two Collaborator approvals for fast-tracking, land the PR. +* Leave a comment in the PR: `Please 👍 this comment to approve fast-tracking`. +* If there are not enough approvals within a reasonable time, consider the + single approval of the onboarding TSC member sufficient, and land the PR. * Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` metadata. * [`node-core-utils`][] automates the generation of metadata and the landing |