diff options
| author | Rich Trott <rtrott@gmail.com> | 2021-07-14 16:39:59 +0300 |
|---|---|---|
| committer | Beth Griggs <bgriggs@redhat.com> | 2021-07-29 13:56:46 +0300 |
| commit | 6979313abb30d381bf36a95637d96fbd43bee694 (patch) | |
| tree | f6d6520e614dfceaee1aec848c76fb7c7519fa5c /onboarding.md | |
| parent | 626eb07fda6653ccab2c5430f244d78f59a63574 (diff) | |
doc: standardize on _pull request_
Sometimes we capitalize _pull request_ and sometimes we don't.
Standardize on lowercase based on Microsoft Style Guide, Chicago Manual
of Style, and GitHub's own docs and UI.
Refs: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests
Refs: https://docs.github.com/en/github/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request
Refs: https://docs.microsoft.com/en-us/style-guide/capitalization
PR-URL: https://github.com/nodejs/node/pull/39384
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Diffstat (limited to 'onboarding.md')
| -rw-r--r-- | onboarding.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/onboarding.md b/onboarding.md index 1cab6132e30..bbe37ce2c86 100644 --- a/onboarding.md +++ b/onboarding.md @@ -184,7 +184,7 @@ The project has two venues for real-time discussion: ## Landing PRs -See the Collaborator Guide: [Landing Pull Requests][]. +See the Collaborator Guide: [Landing pull requests][]. Commits in one PR that belong to one logical change should be squashed. It is rarely the case in onboarding exercises, so this @@ -240,7 +240,7 @@ needs to be pointed out separately during the onboarding. [Code of Conduct]: https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md [Labels]: doc/guides/collaborator-guide.md#labels -[Landing Pull Requests]: doc/guides/collaborator-guide.md#landing-pull-requests +[Landing pull requests]: doc/guides/collaborator-guide.md#landing-pull-requests [Publicizing or hiding organization membership]: https://help.github.com/articles/publicizing-or-hiding-organization-membership/ [`author-ready`]: doc/guides/collaborator-guide.md#author-ready-pull-requests [`core-validate-commit`]: https://github.com/nodejs/core-validate-commit |