diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2021-01-27 14:18:28 +0300 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2021-02-02 12:42:01 +0300 |
| commit | 171001605377e898707db78fef827243e06546d8 (patch) | |
| tree | f6fc685b7028e948287f2334eda8994190e20689 /onboarding.md | |
| parent | 34adf7f74bc1b7ba46de68e020265834fc8948f0 (diff) | |
doc: mention adding Fixes to collaborator onboarding PR
Also update the example to include the Fixes url.
PR-URL: https://github.com/nodejs/node/pull/37097
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Diffstat (limited to 'onboarding.md')
| -rw-r--r-- | onboarding.md | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/onboarding.md b/onboarding.md index 8036e459f51..ba75958db55 100644 --- a/onboarding.md +++ b/onboarding.md @@ -204,11 +204,14 @@ needs to be pointed out separately during the onboarding. ## Exercise: Make a PR adding yourself to the README * Example: - <https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0> - * For raw commit message: `git log ce986de829457c39257cd205067602e765768fb0 - -1` + <https://github.com/nodejs/node/commit/b58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8> + * For raw commit message: + `git show --format=%Bb58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8` * Collaborators are in alphabetical order by GitHub username. * Optionally, include your personal pronouns. +* Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message + so that when the commit lands, the nomination issue url will be + automatically closed. * Label your pull request with the `doc`, `notable-change`, and `fast-track` labels. * Run CI on the PR. Use the `node-test-pull-request` CI task. |