diff options
| author | Rich Trott <rtrott@gmail.com> | 2021-10-22 20:26:39 +0300 |
|---|---|---|
| committer | Node.js GitHub Bot <github-bot@iojs.org> | 2021-10-24 22:01:07 +0300 |
| commit | 566365dd9dd86588f1b6e06b4cba27cf9b107c33 (patch) | |
| tree | 519f7357e191a60a25678e309d648fe3e0d506fb /onboarding.md | |
| parent | ce0e21e50a087ccdf457860ed43d312ad3184c7c (diff) | |
doc: update onboarding task
Make starting Jenkins CI optional.
PR-URL: https://github.com/nodejs/node/pull/40570
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'onboarding.md')
| -rw-r--r-- | onboarding.md | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/onboarding.md b/onboarding.md index 73070bea6e1..8a176951517 100644 --- a/onboarding.md +++ b/onboarding.md @@ -215,7 +215,9 @@ needs to be pointed out separately during the onboarding. labels. The `fast-track` label should cause the Node.js GitHub bot to post a comment in the pull request asking collaborators to approve the pull request by leaving a 👍 reaction on the comment. -* Run CI on the pull request. Use the `node-test-pull-request` CI task. +* Optional: Run CI on the pull request. Use the `node-test-pull-request` CI + task. As a convenience, you may apply the `request-ci` label to the pull + request to have a GitHub Actions workflow start the Jenkins CI task for you. * After two Collaborator approvals for the change and two Collaborator approvals for fast-tracking, land the PR. * If there are not enough approvals within a reasonable time, consider the |