diff options
| author | LiviaMedeiros <livia@cirno.name> | 2022-05-10 22:20:48 +0300 |
|---|---|---|
| committer | Beth Griggs <bgriggs@redhat.com> | 2022-05-16 13:12:15 +0300 |
| commit | 1e9de0dd5a270fb94c3b46cbccf59618902aec2d (patch) | |
| tree | 2ad3dc9d8e7b621e9568185035383139fe250986 /onboarding.md | |
| parent | eb630d7ef98f6f543776fe95f685d08f0f43e740 (diff) | |
doc: remove git:// protocol, adjust nits in onboarding.md
PR-URL: https://github.com/nodejs/node/pull/43045
Refs: https://github.blog/2021-09-01-improving-git-protocol-security-github/
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Diffstat (limited to 'onboarding.md')
| -rw-r--r-- | onboarding.md | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/onboarding.md b/onboarding.md index f17b24c50f1..8fd51809bca 100644 --- a/onboarding.md +++ b/onboarding.md @@ -39,11 +39,11 @@ onboarding session. * Always create a branch in your own GitHub fork for pull requests * Branches in the `nodejs/node` repository are only for release lines * Add the canonical nodejs repository as `upstream` remote: - * `git remote add upstream git://github.com/nodejs/node.git` + * `git remote add upstream git@github.com:nodejs/node.git` * To update from `upstream`: * `git checkout master` - * `git remote update -p` OR `git fetch --all` - * `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`) + * `git fetch upstream HEAD` + * `git reset --hard FETCH_HEAD` * Make a new branch for each pull request you submit. * Membership: Consider making your membership in the Node.js GitHub organization public. This makes it easier to identify collaborators. @@ -203,9 +203,9 @@ needs to be pointed out separately during the onboarding. ## Exercise: Make a pull request adding yourself to the README * Example: - <https://github.com/nodejs/node/commit/b58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8> + <https://github.com/nodejs/node/commit/6669b3857f0f43ee0296eb7ac45086cd907b9e94> * For raw commit message: - `git show --format=%B b58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8` + `git show --format=%B 6669b3857f0f43ee0296eb7ac45086cd907b9e94` * Collaborators are in alphabetical order by GitHub username. * Optionally, include your personal pronouns. * Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message |