diff options
| author | Anna Henningsen <anna@addaleax.net> | 2020-07-07 23:03:17 +0300 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2020-07-14 16:13:34 +0300 |
| commit | a038199265519fa4db88a639b0e438675d23c4d1 (patch) | |
| tree | 66b40d0be7e8c67e9d69593d6e00d8fd2b2ca319 /src/README.md | |
| parent | 2a29650eb328417de68beb617b22e83810e9296a (diff) | |
src,doc,test: remove String::New default parameter
`kNormal` has been the implicit default for a while now (since V8 7.6).
Refs: https://github.com/v8/v8/commit/e0d7f816990ada28ebe1281ca9431236ef8c6e4f
PR-URL: https://github.com/nodejs/node/pull/34248
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/README.md')
| -rw-r--r-- | src/README.md | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/README.md b/src/README.md index a3a6a71aa55..079326cd200 100644 --- a/src/README.md +++ b/src/README.md @@ -146,9 +146,7 @@ v8::Local<v8::Value> GetFoo(v8::Local<v8::Context> context, // The 'foo_string' handle cannot be returned from this function because // it is not “escaped” with `.Escape()`. v8::Local<v8::String> foo_string = - v8::String::NewFromUtf8(isolate, - "foo", - v8::NewStringType::kNormal).ToLocalChecked(); + v8::String::NewFromUtf8(isolate, "foo").ToLocalChecked(); v8::Local<v8::Value> return_value; if (obj->Get(context, foo_string).ToLocal(&return_value)) { |