diff options
author | Gerhard Stoebich <18708370+Flarna@users.noreply.github.com> | 2019-05-05 22:29:32 +0300 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-05-20 00:17:06 +0300 |
commit | 3d9d1ade2a361f408b116c5bafb2fcd560310f9c (patch) | |
tree | 7d0eb2feb0652bc9cf4609df6b1a437ea824303a /src/async_wrap.h | |
parent | ee59763ab3b67f8792ed53a4d098212a040994f9 (diff) |
async_hooks: don't reuse resource in HttpAgent
As discussed in https://github.com/nodejs/diagnostics/issues/248,
https://github.com/nodejs/node/pull/21313 and
https://docs.google.com/document/d/1g8OrG5lMIUhRn1zbkutgY83MiTSMx-0NHDs8Bf-nXxM/preview
reusing the resource object is a blocker for landing a resource based
async hooks API and get rid of the promise destroy hook.
This PR ensures that HttpAgent uses the a new resource object in case
the socket handle gets reused.
PR-URL: https://github.com/nodejs/node/pull/27581
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'src/async_wrap.h')
-rw-r--r-- | src/async_wrap.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/async_wrap.h b/src/async_wrap.h index 3a8789f89ba..0fe41352234 100644 --- a/src/async_wrap.h +++ b/src/async_wrap.h @@ -133,6 +133,7 @@ class AsyncWrap : public BaseObject { static void PushAsyncIds(const v8::FunctionCallbackInfo<v8::Value>& args); static void PopAsyncIds(const v8::FunctionCallbackInfo<v8::Value>& args); static void AsyncReset(const v8::FunctionCallbackInfo<v8::Value>& args); + static void GetProviderType(const v8::FunctionCallbackInfo<v8::Value>& args); static void QueueDestroyAsyncId( const v8::FunctionCallbackInfo<v8::Value>& args); |