diff options
author | Ben Noordhuis <info@bnoordhuis.nl> | 2018-02-21 17:24:18 +0300 |
---|---|---|
committer | Ben Noordhuis <info@bnoordhuis.nl> | 2018-02-21 17:24:18 +0300 |
commit | d4024815b7d55005c3ec25c74cf647f7eba1d5cc (patch) | |
tree | b86653a53494704be52a30b175886bf9ed054cd4 /src/base_object-inl.h | |
parent | 992703f2b50f6b3483e9b930737d177b9e01256d (diff) |
src: remove unnecessary Reset() calls
The previous commit made persistent handles auto-reset on destruction.
This commit removes the Reset() calls that are now no longer necessary.
PR-URL: https://github.com/nodejs/node/pull/18656
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'src/base_object-inl.h')
-rw-r--r-- | src/base_object-inl.h | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/src/base_object-inl.h b/src/base_object-inl.h index 6720bd6d886..51ef4659966 100644 --- a/src/base_object-inl.h +++ b/src/base_object-inl.h @@ -42,11 +42,6 @@ inline BaseObject::BaseObject(Environment* env, v8::Local<v8::Object> handle) } -inline BaseObject::~BaseObject() { - CHECK(persistent_handle_.IsEmpty()); -} - - inline Persistent<v8::Object>& BaseObject::persistent() { return persistent_handle_; } @@ -65,8 +60,7 @@ inline Environment* BaseObject::env() const { template <typename Type> inline void BaseObject::WeakCallback( const v8::WeakCallbackInfo<Type>& data) { - std::unique_ptr<Type> self(data.GetParameter()); - self->persistent().Reset(); + delete data.GetParameter(); } |