diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-05-07 11:24:42 +0300 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-05-09 11:05:23 +0300 |
| commit | 36793b8c650e80ad6f35728d586eda7637703466 (patch) | |
| tree | cdbe89120e4dd7993ba00431f748dc4127e6bebd /src/base_object.h | |
| parent | d5b259e22bdd165929e20ae211f72d71d70c9dae (diff) | |
src: rename handle parameter object
This commit renames the handle parameter for the BaseObject constructor
to object instead of handle.
The motivation for doing this is that when stepping through an
inheritance chain it can sometimes be a little confusing when
HandleWrap is in involved. HandleWrap has a handle parameter
but calls the object that is passed to AsyncWrap object, but
then when you end up in BaseObject it is named handle.
PR-URL: https://github.com/nodejs/node/pull/20570
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/base_object.h')
| -rw-r--r-- | src/base_object.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/base_object.h b/src/base_object.h index 7d8281238b1..2a4967c1aaf 100644 --- a/src/base_object.h +++ b/src/base_object.h @@ -34,9 +34,9 @@ class Environment; class BaseObject { public: - // Associates this object with `handle`. It uses the 0th internal field for + // Associates this object with `object`. It uses the 0th internal field for // that, and in particular aborts if there is no such field. - inline BaseObject(Environment* env, v8::Local<v8::Object> handle); + inline BaseObject(Environment* env, v8::Local<v8::Object> object); virtual inline ~BaseObject(); // Returns the wrapped object. Returns an empty handle when |