diff options
author | Rafael Gonzaga <rafael.nunu@hotmail.com> | 2022-09-14 15:47:40 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-09-14 15:47:40 +0300 |
commit | d3cb193561db6282de8581e6d2eaaf341d8300eb (patch) | |
tree | 8132863ea9cc216766cf469311450ef2e64f8224 /src/cares_wrap.cc | |
parent | c04d87d9ef76d3dbbcb8b3f4980c1deb803452db (diff) |
src: make ReqWrap weak
This commit allows throwing an exception after creating `FSReqCallback`
Co-authored-by: Anna Henningsen <anna@addaleax.net>
PR-URL: https://github.com/nodejs/node/pull/44074
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/cares_wrap.cc')
-rw-r--r-- | src/cares_wrap.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc index 1757d56d09a..d19705f94e7 100644 --- a/src/cares_wrap.cc +++ b/src/cares_wrap.cc @@ -1429,7 +1429,7 @@ static void Query(const FunctionCallbackInfo<Value>& args) { void AfterGetAddrInfo(uv_getaddrinfo_t* req, int status, struct addrinfo* res) { auto cleanup = OnScopeLeave([&]() { uv_freeaddrinfo(res); }); - std::unique_ptr<GetAddrInfoReqWrap> req_wrap { + BaseObjectPtr<GetAddrInfoReqWrap> req_wrap{ static_cast<GetAddrInfoReqWrap*>(req->data)}; Environment* env = req_wrap->env(); @@ -1502,7 +1502,7 @@ void AfterGetNameInfo(uv_getnameinfo_t* req, int status, const char* hostname, const char* service) { - std::unique_ptr<GetNameInfoReqWrap> req_wrap { + BaseObjectPtr<GetNameInfoReqWrap> req_wrap{ static_cast<GetNameInfoReqWrap*>(req->data)}; Environment* env = req_wrap->env(); |