diff options
author | cjihrig <cjihrig@gmail.com> | 2018-12-26 18:11:02 +0300 |
---|---|---|
committer | cjihrig <cjihrig@gmail.com> | 2018-12-31 19:39:00 +0300 |
commit | da9a4d0fb4df8be01cfd5a8d582f9acbb1e10306 (patch) | |
tree | b19be5b3ca3ae7121d13e22e17067901c59db77f /src/cares_wrap.cc | |
parent | 3c5e2372db4f1733fb9ae65baa30ae6c45546c9c (diff) |
src: fix warning in cares_wrap.cc
This commit fixes the following warning:
./src/cares_wrap.cc:1268:5: warning: comparison of integers of
different signs: 'uint32_t' (aka 'unsigned int') and 'int'
[-Wsign-compare]
CHECK_EQ(ret->Length(), a_count + aaaa_count);
PR-URL: https://github.com/nodejs/node/pull/25230
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/cares_wrap.cc')
-rw-r--r-- | src/cares_wrap.cc | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc index 9d7af47dcdb..09cf809dec3 100644 --- a/src/cares_wrap.cc +++ b/src/cares_wrap.cc @@ -1212,15 +1212,15 @@ class QueryAnyWrap: public QueryWrap { ret, addrttls, &naddrttls); - int a_count = ret->Length(); + uint32_t a_count = ret->Length(); if (status != ARES_SUCCESS && status != ARES_ENODATA) { ParseError(status); return; } if (type == ns_t_a) { - CHECK_EQ(naddrttls, a_count); - for (int i = 0; i < a_count; i++) { + CHECK_EQ(static_cast<uint32_t>(naddrttls), a_count); + for (uint32_t i = 0; i < a_count; i++) { Local<Object> obj = Object::New(env()->isolate()); obj->Set(context, env()->address_string(), @@ -1234,7 +1234,7 @@ class QueryAnyWrap: public QueryWrap { ret->Set(context, i, obj).FromJust(); } } else { - for (int i = 0; i < a_count; i++) { + for (uint32_t i = 0; i < a_count; i++) { Local<Object> obj = Object::New(env()->isolate()); obj->Set(context, env()->value_string(), @@ -1258,13 +1258,13 @@ class QueryAnyWrap: public QueryWrap { ret, addr6ttls, &naddr6ttls); - int aaaa_count = ret->Length() - a_count; + uint32_t aaaa_count = ret->Length() - a_count; if (status != ARES_SUCCESS && status != ARES_ENODATA) { ParseError(status); return; } - CHECK_EQ(aaaa_count, naddr6ttls); + CHECK_EQ(aaaa_count, static_cast<uint32_t>(naddr6ttls)); CHECK_EQ(ret->Length(), a_count + aaaa_count); for (uint32_t i = a_count; i < ret->Length(); i++) { Local<Object> obj = Object::New(env()->isolate()); |