diff options
author | Anna Henningsen <anna@addaleax.net> | 2020-03-22 20:00:57 +0300 |
---|---|---|
committer | Myles Borins <mylesborins@google.com> | 2020-03-26 20:58:58 +0300 |
commit | e9e12b8f36db9b5f47989b1ff00867129a17bdce (patch) | |
tree | 7441b0307f3b325bc00a842e3f55f6a154651258 /src/env.h | |
parent | 28e298f219586b6605d852ebe0b1b4418bb0e6fe (diff) |
src: use single ObjectTemplate for TextDecoder
`ObjectTemplate`s are not garbage-collected like regular objects
(for some reason). It is sufficient to create a single template
anyway, so do that to address the memory leak.
Fixes: https://github.com/nodejs/node/issues/32424
PR-URL: https://github.com/nodejs/node/pull/32426
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'src/env.h')
-rw-r--r-- | src/env.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/env.h b/src/env.h index e3d651daac1..6a459f00edb 100644 --- a/src/env.h +++ b/src/env.h @@ -411,6 +411,7 @@ constexpr size_t kFsStatsBufferLength = V(http2settings_constructor_template, v8::ObjectTemplate) \ V(http2stream_constructor_template, v8::ObjectTemplate) \ V(http2ping_constructor_template, v8::ObjectTemplate) \ + V(i18n_converter_template, v8::ObjectTemplate) \ V(libuv_stream_wrap_ctor_template, v8::FunctionTemplate) \ V(message_port_constructor_template, v8::FunctionTemplate) \ V(pipe_constructor_template, v8::FunctionTemplate) \ |