diff options
author | Ben Noordhuis <info@bnoordhuis.nl> | 2014-10-11 18:24:12 +0400 |
---|---|---|
committer | Fedor Indutny <fedor@indutny.com> | 2014-10-12 02:09:16 +0400 |
commit | 97585b0d7ab0084d90faf6bded275b902d76857a (patch) | |
tree | 26853d875786c014e2e9ef5ed2ec18f7ed601775 /src/fs_event_wrap.cc | |
parent | b2e519983f1e92a874a74c11e82027955ef8909a (diff) |
src: remove unnecessary HandleScopes
API callback functions don't need to create a v8::HandleScope instance
because V8 already creates one in the JS->C++ adapter frame.
PR-URL: https://github.com/node-forward/node/pull/16
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Diffstat (limited to 'src/fs_event_wrap.cc')
-rw-r--r-- | src/fs_event_wrap.cc | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/fs_event_wrap.cc b/src/fs_event_wrap.cc index 04f3b997fd8..133acec0701 100644 --- a/src/fs_event_wrap.cc +++ b/src/fs_event_wrap.cc @@ -96,7 +96,6 @@ void FSEventWrap::Initialize(Handle<Object> target, void FSEventWrap::New(const FunctionCallbackInfo<Value>& args) { assert(args.IsConstructCall()); - HandleScope handle_scope(args.GetIsolate()); Environment* env = Environment::GetCurrent(args.GetIsolate()); new FSEventWrap(env, args.This()); } @@ -104,7 +103,6 @@ void FSEventWrap::New(const FunctionCallbackInfo<Value>& args) { void FSEventWrap::Start(const FunctionCallbackInfo<Value>& args) { Environment* env = Environment::GetCurrent(args.GetIsolate()); - HandleScope scope(env->isolate()); FSEventWrap* wrap = Unwrap<FSEventWrap>(args.Holder()); @@ -186,9 +184,6 @@ void FSEventWrap::OnEvent(uv_fs_event_t* handle, const char* filename, void FSEventWrap::Close(const FunctionCallbackInfo<Value>& args) { - Environment* env = Environment::GetCurrent(args.GetIsolate()); - HandleScope scope(env->isolate()); - FSEventWrap* wrap = Unwrap<FSEventWrap>(args.Holder()); if (wrap == NULL || wrap->initialized_ == false) |