diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2014-10-11 18:24:12 +0400 |
|---|---|---|
| committer | Fedor Indutny <fedor@indutny.com> | 2014-10-12 02:09:16 +0400 |
| commit | 97585b0d7ab0084d90faf6bded275b902d76857a (patch) | |
| tree | 26853d875786c014e2e9ef5ed2ec18f7ed601775 /src/handle_wrap.cc | |
| parent | b2e519983f1e92a874a74c11e82027955ef8909a (diff) | |
src: remove unnecessary HandleScopes
API callback functions don't need to create a v8::HandleScope instance
because V8 already creates one in the JS->C++ adapter frame.
PR-URL: https://github.com/node-forward/node/pull/16
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Diffstat (limited to 'src/handle_wrap.cc')
| -rw-r--r-- | src/handle_wrap.cc | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/src/handle_wrap.cc b/src/handle_wrap.cc index 83015f1dfd8..eeda93017fd 100644 --- a/src/handle_wrap.cc +++ b/src/handle_wrap.cc @@ -41,9 +41,6 @@ using v8::Value; void HandleWrap::Ref(const FunctionCallbackInfo<Value>& args) { - Environment* env = Environment::GetCurrent(args.GetIsolate()); - HandleScope scope(env->isolate()); - HandleWrap* wrap = Unwrap<HandleWrap>(args.Holder()); if (wrap != NULL && wrap->handle__ != NULL) { @@ -54,9 +51,6 @@ void HandleWrap::Ref(const FunctionCallbackInfo<Value>& args) { void HandleWrap::Unref(const FunctionCallbackInfo<Value>& args) { - Environment* env = Environment::GetCurrent(args.GetIsolate()); - HandleScope scope(env->isolate()); - HandleWrap* wrap = Unwrap<HandleWrap>(args.Holder()); if (wrap != NULL && wrap->handle__ != NULL) { @@ -68,7 +62,6 @@ void HandleWrap::Unref(const FunctionCallbackInfo<Value>& args) { void HandleWrap::Close(const FunctionCallbackInfo<Value>& args) { Environment* env = Environment::GetCurrent(args.GetIsolate()); - HandleScope scope(env->isolate()); HandleWrap* wrap = Unwrap<HandleWrap>(args.Holder()); |