src: forbid handle allocations from Platform tasks

Platform tasks should have their own handle scopes, rather than
leak into outer ones.

PR-URL: https://github.com/nodejs/node/pull/26376
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 8 insertions, 0 deletions

diff --git a/src/inspector/main_thread_interface.cc b/src/inspector/main_thread_interface.cc
index c58ea4cb410..14f90fbd9d3 100644
--- a/src/inspector/main_thread_interface.cc
+++ b/src/inspector/main_thread_interface.cc
@@ -268,6 +268,14 @@ void MainThreadInterface::DispatchMessages() {
       MessageQueue::value_type task;
       std::swap(dispatching_message_queue_.front(), task);
       dispatching_message_queue_.pop_front();
+
+      // TODO(addaleax): The V8 inspector code currently sometimes allocates
+      // handles that leak to the outside scope, rendering a HandleScope here
+      // necessary. This handle scope can be removed/turned into a
+      // SealHandleScope once/if
+      // https://chromium-review.googlesource.com/c/v8/v8/+/1484304 makes it
+      // into our copy of V8, maybe guarded with #ifdef DEBUG if we want.
+      v8::HandleScope handle_scope(isolate_);
       task->Call(this);
     }
   } while (had_messages);