diff options
author | cjihrig <cjihrig@gmail.com> | 2018-12-09 22:05:43 +0300 |
---|---|---|
committer | Rod Vagg <rod@vagg.org> | 2019-02-28 15:37:42 +0300 |
commit | 2578492dbd6e8619f93a26eed94126b935908627 (patch) | |
tree | 28656c49bd0c2accb3a510cef100a03bd78c02aa /src/inspector_agent.cc | |
parent | 802d0a4382dad14715c3c1f58b7defc9f905759f (diff) |
src: remove use of CallOnForegroundThread()
The V8 platform's CallOnForegroundThread() method is deprecated.
This commit replaces its use with GetForegroundTaskRunner()
functionality instead.
PR-URL: https://github.com/nodejs/node/pull/24925
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/inspector_agent.cc')
-rw-r--r-- | src/inspector_agent.cc | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index f6ceedeb289..ae266ba86a4 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -39,6 +39,8 @@ using v8::Local; using v8::Message; using v8::Object; using v8::String; +using v8::Task; +using v8::TaskRunner; using v8::Value; using v8_inspector::StringBuffer; @@ -49,7 +51,7 @@ using v8_inspector::V8InspectorClient; static uv_sem_t start_io_thread_semaphore; static uv_async_t start_io_thread_async; -class StartIoTask : public v8::Task { +class StartIoTask : public Task { public: explicit StartIoTask(Agent* agent) : agent(agent) {} @@ -854,7 +856,9 @@ void Agent::RequestIoThreadStart() { uv_async_send(&start_io_thread_async); Isolate* isolate = parent_env_->isolate(); v8::Platform* platform = parent_env_->isolate_data()->platform(); - platform->CallOnForegroundThread(isolate, new StartIoTask(this)); + std::shared_ptr<TaskRunner> taskrunner = + platform->GetForegroundTaskRunner(isolate); + taskrunner->PostTask(std::make_unique<StartIoTask>(this)); isolate->RequestInterrupt(StartIoInterrupt, this); uv_async_send(&start_io_thread_async); } |