diff options
| author | Sam Roberts <vieuxtech@gmail.com> | 2019-04-10 01:21:36 +0300 |
|---|---|---|
| committer | Sam Roberts <vieuxtech@gmail.com> | 2019-04-12 22:33:37 +0300 |
| commit | 060d901f87b3d87314f8540eb02f315e2952f581 (patch) | |
| tree | 53159171201703bb6d8a4e780c8624a5c6c8cbb5 /src/inspector_agent.cc | |
| parent | 7b0d8673898e65a368108264c77bccaa3e004028 (diff) | |
src: replace FromJust() with Check() when possible
FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:
To be used, where the actual value of the Maybe is not needed, like
Object::Set.
See: https://github.com/nodejs/node/pull/26929/files#r269256335
PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Diffstat (limited to 'src/inspector_agent.cc')
| -rw-r--r-- | src/inspector_agent.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index 57228ed9533..cda5cdbbd8d 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -403,7 +403,7 @@ void NotifyClusterWorkersDebugEnabled(Environment* env) { // Send message to enable debug in cluster workers Local<Object> message = Object::New(isolate); message->Set(context, FIXED_ONE_BYTE_STRING(isolate, "cmd"), - FIXED_ONE_BYTE_STRING(isolate, "NODE_DEBUG_ENABLED")).FromJust(); + FIXED_ONE_BYTE_STRING(isolate, "NODE_DEBUG_ENABLED")).Check(); ProcessEmit(env, "internalMessage", message); } |