diff options
author | Anna Henningsen <anna@addaleax.net> | 2019-04-18 00:16:22 +0300 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-04-30 01:23:33 +0300 |
commit | 723d5c058fa180684df13bd2a83bbf3ca6201957 (patch) | |
tree | 6aeb4bc88e6c437853327cced05ab797827c22f2 /src/inspector_agent.cc | |
parent | 095bd569aef4fec433ddb26e681eaabff1f7fd10 (diff) |
src: prefer v8::Global over node::Persistent
`v8::Global` is essentially a nicer variant of `node::Persistent` that,
in addition to reset-on-destroy, also implements move semantics.
This commit makes the necessary replacements, removes
`node::Persistent` and (now-)unnecessary inclusions of the
`node_persistent.h` header, and makes some of the functions that
take Persistents as arguments more generic so that they work with all
`v8::PersistentBase` flavours.
PR-URL: https://github.com/nodejs/node/pull/27287
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src/inspector_agent.cc')
-rw-r--r-- | src/inspector_agent.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index 10b607ff6c5..78af5508d07 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -34,6 +34,7 @@ using node::FatalError; using v8::Context; using v8::Function; +using v8::Global; using v8::HandleScope; using v8::Isolate; using v8::Local; @@ -834,7 +835,7 @@ void Agent::DisableAsyncHook() { } void Agent::ToggleAsyncHook(Isolate* isolate, - const node::Persistent<Function>& fn) { + const Global<Function>& fn) { CHECK(parent_env_->has_run_bootstrapping_code()); HandleScope handle_scope(isolate); CHECK(!fn.IsEmpty()); |