diff options
| author | Daijiro Wachi <daijiro.wachi@gmail.com> | 2020-11-01 18:22:31 +0300 |
|---|---|---|
| committer | Daijiro Wachi <daijiro.wachi@gmail.com> | 2020-11-21 18:02:32 +0300 |
| commit | e40ed2856fddbb0a7788dd4d61c10dd3ec01267a (patch) | |
| tree | f84b6710bbd2d7fe6816cf8e10911930ef302dfe /src/inspector_agent.cc | |
| parent | cde87ed761b47da2919a047d1be60a53cdc4541f (diff) | |
src: integrate URL::href() and use in inspector
PR-URL: https://github.com/nodejs/node/pull/35912
Refs: https://github.com/nodejs/node/issues/22610
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'src/inspector_agent.cc')
| -rw-r--r-- | src/inspector_agent.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index c54b2ab17fc..c101bf80d2a 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -638,9 +638,7 @@ class NodeInspectorClient : public V8InspectorClient { if (!IsFilePath(resource_name)) return nullptr; node::url::URL url = node::url::URL::FromFilePath(resource_name); - // TODO(ak239spb): replace this code with url.href(). - // Refs: https://github.com/nodejs/node/issues/22610 - return Utf8ToStringView(url.protocol() + "/" + url.path()); + return Utf8ToStringView(url.href()); } node::Environment* env_; |