diff options
| author | Gus Caplan <me@gus.host> | 2019-04-16 00:09:51 +0300 |
|---|---|---|
| committer | Sam Roberts <vieuxtech@gmail.com> | 2019-05-16 20:52:53 +0300 |
| commit | f2061930c83cb579410a7f26bed726d6568575e3 (patch) | |
| tree | ddcfcc116344fd03d5d04721df49eacb0059dd13 /src/inspector_agent.cc | |
| parent | cca375f4af235ed7e7f763b2e35532ae843a5854 (diff) | |
src: enable V8's WASM trap handlers
This uses SIGSEGV handlers to catch WASM out of bound (OOB) memory
accesses instead of inserting OOB checks inline, resulting in a 25%-30%
speed increase.
Note that installing a custom SIGSEGV handler will break this, resulting
in potentially scary behaviour.
Refs: https://github.com/nodejs/node/issues/14927
PR-URL: https://github.com/nodejs/node/pull/27246
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'src/inspector_agent.cc')
| -rw-r--r-- | src/inspector_agent.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index d8b5d01a285..d551c3a7d73 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -88,7 +88,7 @@ void StartIoInterrupt(Isolate* isolate, void* agent) { #ifdef __POSIX__ -static void StartIoThreadWakeup(int signo) { +static void StartIoThreadWakeup(int signo, siginfo_t* info, void* ucontext) { uv_sem_post(&start_io_thread_semaphore); } |