diff options
| author | Eugene Ostroukhov <eostroukhov@chromium.org> | 2017-11-11 03:01:00 +0300 |
|---|---|---|
| committer | Eugene Ostroukhov <eostroukhov@google.com> | 2017-12-12 02:53:21 +0300 |
| commit | 73ad3f9bea3993b486621aaf9e61484dc37741d4 (patch) | |
| tree | 259b21142e6c4ceedde66deb1eb37a110e317d9e /src/inspector_agent.h | |
| parent | e51fb90a6db53588ab2b884e4309d4eea9e37bbd (diff) | |
inspector: Fix crash for WS connection
Attaching WS session will now include a roundtrip onto the main thread
to make sure there is no other session (e.g. JS bindings)
This change also required refactoring WS socket implementation to better
support scenarios like this.
Fixes: https://github.com/nodejs/node/issues/16852
PR-URL: https://github.com/nodejs/node/pull/17085
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Diffstat (limited to 'src/inspector_agent.h')
| -rw-r--r-- | src/inspector_agent.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/inspector_agent.h b/src/inspector_agent.h index 29b9546b514..a2d61d0c8db 100644 --- a/src/inspector_agent.h +++ b/src/inspector_agent.h @@ -48,7 +48,6 @@ class Agent { bool IsStarted() { return !!client_; } // IO thread started, and client connected - bool IsConnected(); bool IsWaitingForConnect(); void WaitForDisconnect(); |