Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBen Noordhuis <info@bnoordhuis.nl>2018-02-21 17:24:18 +0300
committerBen Noordhuis <info@bnoordhuis.nl>2018-02-21 17:24:18 +0300
commitd4024815b7d55005c3ec25c74cf647f7eba1d5cc (patch)
treeb86653a53494704be52a30b175886bf9ed054cd4 /src/inspector_js_api.cc
parent992703f2b50f6b3483e9b930737d177b9e01256d (diff)
src: remove unnecessary Reset() calls
The previous commit made persistent handles auto-reset on destruction. This commit removes the Reset() calls that are now no longer necessary. PR-URL: https://github.com/nodejs/node/pull/18656 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'src/inspector_js_api.cc')
-rw-r--r--src/inspector_js_api.cc5
1 files changed, 0 insertions, 5 deletions
diff --git a/src/inspector_js_api.cc b/src/inspector_js_api.cc
index 9a4857f1a10..1cced9420ae 100644
--- a/src/inspector_js_api.cc
+++ b/src/inspector_js_api.cc
@@ -84,10 +84,6 @@ class JSBindingsConnection : public AsyncWrap {
inspector->Connect(&delegate_);
}
- ~JSBindingsConnection() override {
- callback_.Reset();
- }
-
void OnMessage(Local<Value> value) {
MakeCallback(callback_.Get(env()->isolate()), 1, &value);
}
@@ -111,7 +107,6 @@ class JSBindingsConnection : public AsyncWrap {
delegate_.Disconnect();
if (!persistent().IsEmpty()) {
ClearWrap(object());
- persistent().Reset();
}
delete this;
}