diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-09-23 20:24:33 +0300 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-10-03 23:43:42 +0300 |
| commit | d527dde3600655eae7ce0ba5da9263ec4560cd11 (patch) | |
| tree | cb9186b8b85a696ec7f916f40fcec935ba86fdc9 /src/inspector_js_api.cc | |
| parent | 2ebdba12297348649620e3d302b156c149d85a6e (diff) | |
src: use JS inheritance for `AsyncWrap`
For all classes descending from `AsyncWrap`, use JS inheritance
instead of manually adding methods to the individual classes.
This allows cleanup of some code around transferring handles
over IPC.
PR-URL: https://github.com/nodejs/node/pull/23094
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/inspector_js_api.cc')
| -rw-r--r-- | src/inspector_js_api.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/inspector_js_api.cc b/src/inspector_js_api.cc index 52184111f55..49e1dcc6e8a 100644 --- a/src/inspector_js_api.cc +++ b/src/inspector_js_api.cc @@ -307,7 +307,7 @@ void Initialize(Local<Object> target, Local<Value> unused, env->NewFunctionTemplate(JSBindingsConnection::New); tmpl->InstanceTemplate()->SetInternalFieldCount(1); tmpl->SetClassName(conn_str); - AsyncWrap::AddWrapMethods(env, tmpl); + tmpl->Inherit(AsyncWrap::GetConstructorTemplate(env)); env->SetProtoMethod(tmpl, "dispatch", JSBindingsConnection::Dispatch); env->SetProtoMethod(tmpl, "disconnect", JSBindingsConnection::Disconnect); target |