diff options
| author | Eugene Ostroukhov <eostroukhov@chromium.org> | 2016-12-12 21:51:18 +0300 |
|---|---|---|
| committer | Eugene Ostroukhov <eostroukhov@chromium.org> | 2016-12-14 20:54:07 +0300 |
| commit | 3c29b2f8512d4d2d702a2a2f985106a312818ddc (patch) | |
| tree | eca08433f8a78efc5f561df23f5f0e0e93ad1d6c /src/inspector_socket_server.cc | |
| parent | b79e83e7f6458fe5bb180731a2fdb9341a22514e (diff) | |
inspector: fix Coverity defects
One defect remains - Coverity believes that a session object is never
freed while in reality its lifespan is tied to a libuv socket.
PR-URL: https://github.com/nodejs/node/pull/10240
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Diffstat (limited to 'src/inspector_socket_server.cc')
| -rw-r--r-- | src/inspector_socket_server.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/inspector_socket_server.cc b/src/inspector_socket_server.cc index e05a0c577da..4bd35ae8bed 100644 --- a/src/inspector_socket_server.cc +++ b/src/inspector_socket_server.cc @@ -210,6 +210,7 @@ InspectorSocketServer::InspectorSocketServer(SocketServerDelegate* delegate, int port) : loop_(nullptr), delegate_(delegate), port_(port), + server_(uv_tcp_t()), closer_(nullptr), next_session_id_(0) { } @@ -400,6 +401,7 @@ void InspectorSocketServer::SocketConnectedCallback(uv_stream_t* server, int status) { if (status == 0) { InspectorSocketServer* socket_server = InspectorSocketServer::From(server); + // Memory is freed when the socket closes. SocketSession* session = new SocketSession(socket_server, socket_server->next_session_id_++); if (inspector_accept(server, session->Socket(), HandshakeCallback) != 0) { |